test(transpile): add failing test for cooperative threading intrinsics - #2088
Open
TartanLlama wants to merge 5 commits into
Open
test(transpile): add failing test for cooperative threading intrinsics#2088TartanLlama wants to merge 5 commits into
TartanLlama wants to merge 5 commits into
Conversation
TartanLlama
requested review from
andreiltd and
vados-cosmonic
as code owners
September 9, 2026 09:31
TartanLlama
force-pushed
the
sy/coop-thread-test
branch
from
September 9, 2026 09:42
d6bd32e to
f7028f5
Compare
TartanLlama
force-pushed
the
sy/coop-thread-test
branch
from
September 9, 2026 10:08
7163a66 to
c1998a0
Compare
vados-cosmonic
previously approved these changes
Sep 9, 2026
vados-cosmonic
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 🚀
Thanks for updating the SDK version!
Collaborator
|
BTW commitlint error: looks like |
TartanLlama
force-pushed
the
sy/coop-thread-test
branch
from
September 9, 2026 11:02
c1998a0 to
9ed9cc8
Compare
Collaborator
|
OK, so it looks like there might actually be an unexpected bug that has nothing to do with this PR but triggers it because of the sdk update? Will look into it |
Collaborator
|
OK, so it looks like there was a problem calling destructors in components that have this sort of... outside-of-task execution via core functions, fix is #2089 -- once it merges I think you should be able to rebase to |
Signed-off-by: Sy Brand <sy.brand@fastly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've ported over one of the POSIX Open Test suite tests that we use in testing wasi-libc's threading implementation.
My idea is that we can use this as basic validation for the jco implementation, then port over more tests from there to build more confidence in it and find edge cases.