Replace unmaintained decompress package with tar + fflate - #32
Merged
tschneidereit merged 1 commit intoJul 8, 2026
Merged
Conversation
vavsab
force-pushed
the
fix/decompress-cve-use-tar
branch
from
July 8, 2026 08:47
d49a9bb to
77b466a
Compare
Drop `decompress` / `decompress-tar` / `decompress-unzip` in favour of `tar` (isaacs/node-tar) for .tar and `fflate` for .zip. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vavsab
force-pushed
the
fix/decompress-cve-use-tar
branch
from
July 8, 2026 08:50
77b466a to
e2b16a7
Compare
Contributor
Author
|
@tschneidereit Please review. I am available to perform adjustments if needed |
tschneidereit
changed the title
tschneidereit
approved these changes
Jul 8, 2026
tschneidereit
left a comment
tschneidereit
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thank you!
Contributor
Author
|
@tschneidereit Thanks for merging! Anything I can do to help to create a new release here? |
Member
|
That'd make sense to do, yes. Please take a look at bytecodealliance/wizer#143 for how wizer as an extremely similar project is doing this. |
einarfd
added a commit
to einarfd/wiremirage
that referenced
this pull request
Aug 13, 2026
…y risk Three Dependabot alerts (GHSA zip-slip / arbitrary-file-write / arbitrary- hardlink-creation in the abandoned `decompress` npm package) come through componentize-js -> @bytecodealliance/weval -> decompress. No fix exists to bump to on npm today, so this can't be closed the way the Cargo-side advisories were. Traced weval's actual usage: decompress only extracts weval's own precompiled binary, downloaded from a fixed, version-pinned github.com/bytecodealliance/weval release tag, inside the throwaway js-engine-builder Docker stage — never attacker- or SUT-controlled input, never part of the shipped image or reachable at mock-dispatch time. Residual risk is a supply-chain trust assumption on that release asset. Upstream already merged the fix (bytecodealliance/weval#32, decompress -> tar+fflate, 2026-07-08) but hasn't published a release past it yet (npm latest is still 0.4.1). This should resolve itself on the next componentize-js/weval bump. Left a comment in build.mjs (same spot/style as the typescript-6 pin note) so this doesn't need re-investigating from scratch. Alerts #7, #8, #9 are the GitHub-side counterpart — dismiss manually as tolerable_risk (the token this session used lacks the security_events scope to do it via API).
einarfd
added a commit
to einarfd/wiremirage
that referenced
this pull request
Aug 24, 2026
…y risk Three Dependabot alerts (GHSA zip-slip / arbitrary-file-write / arbitrary- hardlink-creation in the abandoned `decompress` npm package) come through componentize-js -> @bytecodealliance/weval -> decompress. No fix exists to bump to on npm today, so this can't be closed the way the Cargo-side advisories were. Traced weval's actual usage: decompress only extracts weval's own precompiled binary, downloaded from a fixed, version-pinned github.com/bytecodealliance/weval release tag, inside the throwaway js-engine-builder Docker stage — never attacker- or SUT-controlled input, never part of the shipped image or reachable at mock-dispatch time. Residual risk is a supply-chain trust assumption on that release asset. Upstream already merged the fix (bytecodealliance/weval#32, decompress -> tar+fflate, 2026-07-08) but hasn't published a release past it yet (npm latest is still 0.4.1). This should resolve itself on the next componentize-js/weval bump. Left a comment in build.mjs (same spot/style as the typescript-6 pin note) so this doesn't need re-investigating from scratch. Alerts #7, #8, #9 are the GitHub-side counterpart — dismiss manually as tolerable_risk (the token this session used lacks the security_events scope to do it via API).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #30 / suggested by @tschneidereit.
Drops
decompress/decompress-tar/decompress-unzip(GHSA-mp2f-45pm-3cg9) in favour oftar(isaacs/node-tar) for.tar.xzandfflatefor.zip. Call-site semantics are unchanged.npm auditreports 0 vulnerabilities.