Repository navigation
Round 23: split census.manifest into a package (no behaviour change); STATUS.md, CLAUDE.md, plan archive - #20
Merged
Conversation
…our change; golden snapshot script for acceptance
…on table, rules, backlog), CLAUDE.md (commands, hard rules, reading budget), archive PLAN_ROUND_1-22 (kept at tag v0.21.0)
…_analysed_data, validate_manifest); point them at census.manifest.run and assert they are called. STATUS.md: manifest package layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the manifest module into focused modules without changing scientific behavior or rendered methods/validation results. The original facade docstring and every baseline public/private/imported attribute remain available.
What moved where
Section 6 acceptance outputs
Baseline: 1,634 passed / 37 skipped. All 478 snapshots from 11 manifests are byte-identical. All 122 baseline names are preserved (132 after package child-module names). No production function/constant names or messages changed; moved function bodies/comments were checked verbatim apart from relative import depth before the two golden-covered extractions. No run_manifest split or feature/bug work is included.
Section 0.7 least-change exceptions: the packaging test's exact expected list had to include the required subpackage, and the full suite exposed an omitted _run_analysis spy in tests/test_manifest_multistate.py. Only that patch target and the three listed failing targets were retargeted; assertions were not weakened. Listed tests that passed unchanged were left unchanged, including the documented fault-injection coverage caveat.
Documentation changes are one exact source-path substitution in STATUS.md and the requested changelog entry. Study/audit content was not reviewed or edited. No other application modules, dependency, version, tag or release changes. All commits carry skip markers; GitHub CI was not run. No merge is requested.
Status table
run_manifeststages (for later)Planner review
test_manifest_multistatespy) are correct; the plan missed them.mock.patchoncensus.manifest._write_analysed_data(test_tract_harmonization) and oncensus.manifest.validate_manifest(test_manifest_releases) no longer reached the calls insidecensus/manifest/run.py, so both tests passed without injecting anything. Both now patchcensus.manifest.runand assert the mock was called. The twocensus.manifest.run_manifestpatches still work (the caller looks the name up through the facade at call time).scripts/refactor_golden.py,STATUS.md,CLAUDE.mdand the removal ofPLAN_ROUND_1–22from the tree (kept at tag v0.21.0).