Repository navigation
Tests: fix 3 Windows-only WONDER fixture failures (CRLF changed the pinned SHA-256) - #21
Merged
Merged
Conversation
… Windows (text mode turned LF into CRLF; 3 Windows-only failures since Round 21)
…-progress Round 24 edits from the working tree; this PR is only the one-line test fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CI has failed the same 3 tests since Round 21 (
tests/test_round21_part2.py::TestWonder: refusals_and_measure, via_load_external, zero_deaths_keep_finite_se). The fixture is written in text mode, so Windows turns LF into CRLF, and the file no longer matches the SHA-256 computed from the in-memory text. The code under test is correct (it is meant to refuse a changed export).Fix: write the fixture with
newline="". One line, test only. The TestWonder tests pass locally on Linux; Windows to be confirmed by this PR's CI.