Repository navigation
fix(qoder): bound ensureMeaningfulUpstream after 200 (#344) - #345
Merged
Merged
Conversation
Reuse QODER_STREAM_TTFB_MS / Direct.ttfb so heartbeat-only SSE after a 200 fails over with upstream_empty instead of hanging forever. Apply the same deadline to qwenwork for consistency.
The TTFB timeout timer and the read-error path both Close the body; cancelOnCloseBody.Close is not concurrency-safe, so race detector failed TestDirectChatStreamTimesOutHeartbeatOnlyUpstream. Use sync.Once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #344
Qoder PAT in-process
ChatStreamuseddoWithFirstByteTimeoutonly until response headers. After a 200,ensureMeaningfulUpstreamloopedbr.ReadString('\n')with no deadline, so a heartbeat-only SSE stream hung the client forever (norequest_stream_diagnostics).Changes
ensureMeaningfulUpstream(resp, timeout)with a deadline that reusesQODER_STREAM_TTFB_MS/Direct.ttfb/resolveFirstByteTimeout()(default 30s).emptyUpstreamError()(upstream_empty) so the executor can fail over.internal/providers/qwenworkensureMeaningfulUpstream(30s default) for consistency — same hang shape.upstream_empty; meaningful line within bound → success + bytes preserved.Test plan
go test ./internal/providers/qoder/ ./internal/providers/qwenwork/python3 scripts/release-notes.py self-test && validateDo not merge from this PR description; leave for review.