fix: improve ref-based interaction recovery - #2167
Merged
Merged
Conversation
|
Size Report
npm unpacked components
Startup median (7 runs, lower is better):
Top changed chunks:
Top changed packed files
|
Member
Author
|
Reviewed exact head
The Android live run exercises suffix-drop → exact-ref suggestion → successful fill. The iOS evidence covers exact-ref recovery; its separate fill attempt was blocked by an unrelated modal and is not overstated. Clean for human review; merge remains a maintainer decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fill @refas replacement text, sofill @e57 good morningentersgood morninginstead of interpretinggoodas a fallback label.TEXT_INPUT_COMMIT_NOT_OBSERVEDrecovery inspect the field first, then retry a quoted pacedfillonly when the value is actually missing.Validation
pnpm check:affected --base origin/main --head HEAD --run: all runnable checks passed, including 311 related test files / 2,344 tests and provider integration.@e24suffix returned@e24~s467960; the model retried it directly,fillreported 12 characters, and the settled snapshot showedgood morningbefore send.@e40suggested@e40~s362848). That scenario was ultimately blocked by an unrelated Element “Threads no longer experimental” modal, so it is not claimed as iOS fill success evidence.TEXT_INPUT_COMMIT_NOT_OBSERVEDfollowed immediately by a snapshot containing the complete expected value, motivating inspect-before-retry guidance without weakening verification.The PR touches 10 files in the interaction command family (source, tests, Apple recovery text, help, and docs). Scope did not grow beyond ref-based interaction and text-entry recovery. Benchmark harness cleanup and benchmark artifacts are intentionally excluded.