You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Move legacy local readiness out of device/session resolution into the shared request-runtime admission seam. Local-family requests reuse existing readiness only after facts, binding, and claim admission; provider-owned requests remain claim-free and unchanged; managed-local readiness rejects absent allocator confirmation and never calls family readiness. Sessionless snapshot/selector, keyboard/app-event, clipboard, settings/alert, and recording paths use the same fence. Managed lifecycle cells and the allocator port remain unchanged.
Validation
Planted-red proof: pre-fix session-clipboard ordering test failed (expected 7 to be less than 5); fixed test passes.
pnpm build
pnpm check:affected --run
Focused admission/claim suite: 8 files, 98 tests passed, including exact-owner/fence/incarnation, cancellation, disposal, refusal, and retry coverage.
No live device evidence owed: no real device-facing path, Simlock client, Host transport, or managed registration was added.
Review complete at exact head bfe889e. The change moves legacy readiness behind the existing request binding/claim seam, preserves each former call family’s readiness condition, skips provider-owned runtimes by owner kind, fails managed-local readiness closed with typed reason managed-readiness-unavailable, and keeps local-family as the sole path to the legacy readiness implementation. No parallel lifecycle owner or new readiness state machine was introduced. The planted-red ordering proof and focused regression coverage are meaningful, and all exact-head checks are green, including Integration, Coverage, platform lanes, Repo Guards, and Size. No remaining code-review finding; ready for human merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move legacy local readiness out of device/session resolution into the shared request-runtime admission seam. Local-family requests reuse existing readiness only after facts, binding, and claim admission; provider-owned requests remain claim-free and unchanged; managed-local readiness rejects absent allocator confirmation and never calls family readiness. Sessionless snapshot/selector, keyboard/app-event, clipboard, settings/alert, and recording paths use the same fence. Managed lifecycle cells and the allocator port remain unchanged.
Validation
session-clipboardordering test failed (expected 7 to be less than 5); fixed test passes.pnpm buildpnpm check:affected --runbfe889ec93.