Repository navigation
docs(help): route stale React Native state to reads, not UI navigation - #4231
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex SentinelVerdict: Since the last review: 0 new · 0 still open · 0 no longer raised No findings. Not in the reviewers' prompt (3 files)
Reviewed with this repository's own Sentinel configuration ( Reply under an inline comment with Earlier reviewsReview of
|
|
At a5052c5, the routing rule is right and the Three things in the new Stale state text are worth fixing before merge, since this help is what gets followed literally:
The three open inline threads (the test pin, the AsyncStorage layout and the |
3fb46de to
5b9d769
Compare
|
Fixes at 5b9d769 for the three review points:
Whether |
|
At 5b9d769, |
|
At 5b9d769, the code looks good. All three points from the earlier review are fixed: the storage line is scoped to the AsyncStorage 1.x/2.x layout, The Coverage job fails, but this diff only changes help strings and one help test, so it looks like the platform-apple launch-confirmation timing failure seen on other PRs; a re-run should settle it. I could not check the |
…dp topic Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
5b9d769 to
d43b18d
Compare
|
Rebased on main at d43b18d. The Coverage failure was the Also shortened the guidance without dropping a limit: Stale state is now 5 lines (read the value, use |
|
I found no problems at d43b18d, and the review at 5b9d769 still holds. The new commit only shortens help text, and the qualifiers the earlier fixes added (debuggable, local-only, 1.x/2.x, newer store) are still in the Stale state section of All 17 checks pass and there are no conflicts. The earlier Coverage failure was the launch-confirmation flake fixed on main by #4225. Nothing else needs to happen before merge. |
Summary
help react-nativegains a short Stale state section and a routing line. When a wrong or stale value may come from app state or storage (AsyncStorage, MMKV, a feature flag), the agent reads the value instead of navigating the UI to infer it:agent-device cdp runtime eval --expr '<expression>' --awaitfor JS state, and the AsyncStorage location on an iOS simulator or Android.cdp; the routing was missing.react-nativetopic moves verbatim tosrc/commands/schema/cli-help-react-native.ts, because the addition pushedcli-help.tspast the 1000-line lint limit. Same pattern as the gestures and foldable topics.Validation
a5052c55736413293824cd8df58f057259d22fb1pnpm check:affected --run --head a5052c55736413293824cd8df58f057259d22fb1: format, lint, typecheck, layering, fallow, build, vitest-related and unit passed (exactCommit=true).cli-help-topics.test.tsasserts the new eval command and the AsyncStorage path.origin/main: identical except the added lines.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.