Repository navigation
feat(lease): name a backend baseline in a proxy lease device spec #4236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
V3RON
wants to merge
1
commit into
main
Choose a base branch
from
feat/device-baseline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+261
−28
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -277,6 +277,7 @@ export const LEASE_DEVICE_SPEC_KEYS = [ | |||||
| 'osVersion', | ||||||
| 'imageTag', | ||||||
| 'deviceMode', | ||||||
| 'deviceBaseline', | ||||||
| 'physical', | ||||||
| ] as const satisfies readonly (keyof CommandFlags & keyof LeaseDeviceSpec)[]; | ||||||
|
|
||||||
|
|
@@ -331,13 +332,20 @@ export type LeaseDeviceSpecReading = { | |||||
|
|
||||||
| /** | ||||||
| * The one decision on what a device spec names, for the CLI, the SDK, MCP and the daemon alike. | ||||||
| * Each key is named, not named, or invalid: a non-blank `osVersion`, `imageTag` or `deviceMode` and | ||||||
| * Each key is named, not named, or invalid: a non-blank `osVersion`, `imageTag`, `deviceMode` or | ||||||
| * `deviceBaseline` and | ||||||
| * `physical: true` are named, with the value as given; an absent key, a blank string and | ||||||
| * `physical: false` name nothing; any other type is invalid. | ||||||
| */ | ||||||
| export function readLeaseDeviceSpec( | ||||||
| source: | ||||||
| | { osVersion?: unknown; imageTag?: unknown; deviceMode?: unknown; physical?: unknown } | ||||||
| | { | ||||||
| osVersion?: unknown; | ||||||
| imageTag?: unknown; | ||||||
| deviceMode?: unknown; | ||||||
| deviceBaseline?: unknown; | ||||||
| physical?: unknown; | ||||||
| } | ||||||
| | undefined, | ||||||
| ): LeaseDeviceSpecReading { | ||||||
| const spec: Record<string, string | boolean> = {}; | ||||||
|
|
@@ -371,34 +379,47 @@ export function readLeaseDevice(value: unknown): LeaseDevice | undefined { | |||||
| if (!model || !osVersion || typeof record.physical !== 'boolean') return undefined; | ||||||
| const imageTag = nonEmptyString(record.imageTag); | ||||||
| const deviceMode = nonEmptyString(record.deviceMode); | ||||||
| const baseline = readLeaseDeviceBaseline(record.baseline); | ||||||
| return { | ||||||
| model, | ||||||
| osVersion, | ||||||
| ...(imageTag ? { imageTag } : {}), | ||||||
| ...(deviceMode ? { deviceMode } : {}), | ||||||
| ...(baseline ? { baseline } : {}), | ||||||
| physical: record.physical, | ||||||
| }; | ||||||
| } | ||||||
|
|
||||||
| function readLeaseDeviceBaseline(value: unknown): LeaseDevice['baseline'] { | ||||||
| if (!value || typeof value !== 'object' || Array.isArray(value)) return undefined; | ||||||
| const record = value as Record<string, unknown>; | ||||||
| const name = nonEmptyString(record.name); | ||||||
| const { version } = record; | ||||||
| if (!name || typeof version !== 'number' || !Number.isInteger(version) || version < 1) { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: Prompt for AI agents
Suggested change
|
||||||
| return undefined; | ||||||
| } | ||||||
| return { name, version }; | ||||||
| } | ||||||
|
|
||||||
| /** The refusal for a request whose device spec nothing on its path can honour. */ | ||||||
| export function deviceSpecUnsupportedError( | ||||||
| keys: readonly string[], | ||||||
| message = 'This daemon cannot pick a device by OS version, image tag, device mode, or physical/virtual class.', | ||||||
| message = 'This daemon cannot pick a device by OS version, image tag, device mode, baseline, or physical/virtual class.', | ||||||
| details: Record<string, unknown> = {}, | ||||||
| ): AppError { | ||||||
| return new AppError('UNSUPPORTED_OPERATION', message, { | ||||||
| ...details, | ||||||
| reason: DEVICE_SPEC_UNSUPPORTED_REASON, | ||||||
| keys: [...keys], | ||||||
| hint: 'Drop --os, --image-tag, --device-mode and --physical, or connect through a proxy whose backend picks devices by spec.', | ||||||
| hint: 'Drop --os, --image-tag, --device-mode, --device-baseline and --physical, or connect through a proxy whose backend picks devices by spec.', | ||||||
| }); | ||||||
| } | ||||||
|
|
||||||
| /** The refusal for a request giving a device-spec key a value of the wrong type. */ | ||||||
| export function deviceSpecInvalidError(keys: readonly string[]): AppError { | ||||||
| return new AppError( | ||||||
| 'INVALID_ARGS', | ||||||
| 'osVersion, imageTag and deviceMode take a string, and physical takes a boolean.', | ||||||
| 'osVersion, imageTag, deviceMode and deviceBaseline take a string, and physical takes a boolean.', | ||||||
| { reason: DEVICE_SPEC_INVALID_REASON, keys: [...keys] }, | ||||||
| ); | ||||||
| } | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2:
readLeaseDevicetrimsbaseline.name, but device-spec requests preserve names as given; a valid echoed name with surrounding whitespace is therefore rejected as a mismatch. Preserve the original string while only trimming to test whether it is blank.Prompt for AI agents