Repository navigation
refactor(apple): make runner surface policy explicit #4251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1e2a154
refactor(apple): declare and cross-check runner surface policies
thymikee 1e1aab4
test(apple): name surface policy coverage for its trait owner
thymikee 1ad7895
refactor(apple): keep the surface policy type with its owner
thymikee d2de6a8
refactor(apple): trim surface policy parity coverage
thymikee 67d90c8
docs(adr): keep the lit-panel refusal contract in ADR 0025
thymikee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
39 changes: 39 additions & 0 deletions
39
apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerSurfacePolicy.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import XCTest | ||
|
|
||
| enum RunnerSurfacePolicy: String { | ||
| case none | ||
| case appWindows = "app-windows" | ||
| case observedScreen = "observed-screen" | ||
| case resolvedModal = "resolved-modal" | ||
| } | ||
|
|
||
| extension CommandType { | ||
| var surfacePolicy: RunnerSurfacePolicy { | ||
| switch self { | ||
| case .mouseClick, .remotePress, .desktopScroll, .snapshotBridge, .home, .rotate, | ||
| .actionButton, .volumeUp, .volumeDown, .keyboardReturn, .recordStop, .status, .uptime, | ||
| .appState, .pasteboardWrite, .activate, .terminate, .targetReset, .shutdown: | ||
| return .none | ||
| case .tap, .longPress, .drag, .type, .swipe, .scroll, .findText, .querySelector, .readText, | ||
| .snapshot, .backInApp, .backSystem, .gesture, .gestureViewport, .appSwitcher, | ||
| .keyboardDismiss, .sequence: | ||
| return .appWindows | ||
| case .screenshot, .recordStart: | ||
| return .observedScreen | ||
| case .alert: | ||
| return .resolvedModal | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension RunnerTests { | ||
| @MainActor | ||
| func prepareCommandSurface(command: Command, app: XCUIApplication) -> RunnerAppScreenCaptureFailure? { | ||
| switch command.command.surfacePolicy { | ||
| case .appWindows: | ||
| return bookRequestLitPanelSurface(app: app) | ||
| case .none, .observedScreen, .resolvedModal: | ||
| return nil | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "tap": "app-windows", | ||
| "mouseClick": "none", | ||
| "longPress": "app-windows", | ||
| "drag": "app-windows", | ||
| "remotePress": "none", | ||
| "type": "app-windows", | ||
| "swipe": "app-windows", | ||
| "scroll": "app-windows", | ||
| "desktopScroll": "none", | ||
| "findText": "app-windows", | ||
| "querySelector": "app-windows", | ||
| "readText": "app-windows", | ||
| "snapshot": "app-windows", | ||
| "snapshotBridge": "none", | ||
| "screenshot": "observed-screen", | ||
| "backInApp": "app-windows", | ||
| "backSystem": "app-windows", | ||
| "home": "none", | ||
| "rotate": "none", | ||
| "gesture": "app-windows", | ||
| "gestureViewport": "app-windows", | ||
| "appSwitcher": "app-windows", | ||
| "actionButton": "none", | ||
| "volumeUp": "none", | ||
| "volumeDown": "none", | ||
| "keyboardDismiss": "app-windows", | ||
| "keyboardReturn": "none", | ||
| "alert": "resolved-modal", | ||
| "sequence": "app-windows", | ||
| "recordStart": "observed-screen", | ||
| "recordStop": "none", | ||
| "status": "none", | ||
| "uptime": "none", | ||
| "appState": "none", | ||
| "pasteboardWrite": "none", | ||
| "activate": "none", | ||
| "terminate": "none", | ||
| "targetReset": "none", | ||
| "shutdown": "none" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.