Repository navigation
refactor(apple): name the foreground reading type - #4271
Conversation
Export SystemSurfaceForegroundReading and use it in the probe signature and both route sites. The native wedge test block now says it pins the stale abandon stamp, and its expectation names the abandonment it waits for. Follow-up to #4267.
Size Report
Startup median (7 runs, lower is better):
|
|
Validation at f9869c4:
|
Apex SentinelVerdict: No findings. 1 finding below Reviewed with this repository's own Sentinel configuration ( Reply under an inline comment with |
|
At f9869c4 the rename is right: |
This PR applies the optional items from the #4267 review (#4267 (comment)). It does not change behavior.
system-surface-foreground.tsexportsSystemSurfaceForegroundReading. The probe signature and bothsnapshot-route.tssites use it in place ofAwaited<ReturnType<SystemSurfaceForegroundProbe>>.secondAbandoned, because the expectation waits for the abandonment, not for the read to drain.Validation: tested at f9869c4. The
check:affectedreceipt and the native run follow in a comment.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.