Skip to content

refactor(apple): name the foreground reading type - #4271

Merged
thymikee merged 1 commit into
mainfrom
chore/foreground-reading-type
Nov 6, 2026
Merged

thymikee merged 1 commit into
mainfrom
chore/foreground-reading-type

Conversation

@thymikee

@thymikee thymikee commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

This PR applies the optional items from the #4267 review (#4267 (comment)). It does not change behavior.

  • system-surface-foreground.ts exports SystemSurfaceForegroundReading. The probe signature and both snapshot-route.ts sites use it in place of Awaited<ReturnType<SystemSurfaceForegroundProbe>>.
  • The native wedge test block has a comment that says it pins the stale abandon stamp. Its expectation is renamed to secondAbandoned, because the expectation waits for the abandonment, not for the read to drain.

Validation: tested at f9869c4. The check:affected receipt and the native run follow in a comment.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

Export SystemSurfaceForegroundReading and use it in the probe signature and both
route sites. The native wedge test block now says it pins the stale abandon
stamp, and its expectation names the abandonment it waits for.

Follow-up to #4267.
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.15 MB 6.15 MB 0 B
Package (unpacked) 6.15 MB 6.15 MB 0 B
Package (download) 1.86 MB 1.86 MB 0 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.1 ms 23.9 ms -2.2 ms
CLI --help 72.3 ms 54.1 ms -18.2 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@thymikee

thymikee commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

Validation at f9869c4:

  • pnpm check:affected --run --head f9869c44a7 passed with exactCommit=true (format, lint, typecheck, layering, fallow, native-dupes, build, vitest-related, unit, xctest-selection, packaged-runner-swift).
  • The native runner was built with AGENT_DEVICE_XCUITEST_INCLUDE_UNIT_TESTS=1 (Xcode 26.2). xcodebuild test-without-building -only-testing:AgentDeviceRunnerUITests/RunnerTests/testAbandonedReadBecomesWedgedUntilItReturns on a dedicated iOS 26.2 Simulator executed 1 test with 0 failures.

@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel

Verdict: approve

No findings.

1 finding below minor not shown (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (a68693c72e7c).

Reply under an inline comment with @apex-sentinel-staging note ... or @apex-sentinel-staging pivot ... to re-check that finding.
Comment @apex-sentinel-staging review on this conversation to run a full review.

@thymikee

thymikee commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

At f9869c4 the rename is right: SystemSurfaceForegroundReading replaces both Awaited<ReturnType<...>> sites with no behavior change. All 17 checks pass and there are no conflicts. The test comment and expectation rename in RunnerTests+SnapshotBridgeTests.swift are unrelated to the type naming, but the PR body discloses them.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 6, 2026
@thymikee
thymikee merged commit 3aa6f95 into main Nov 6, 2026
17 checks passed
@thymikee
thymikee deleted the chore/foreground-reading-type branch November 6, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant