Repository navigation
feat(navigation-bar): modernize to Material Design 3 #5006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c3aef33
e0da53e
b384ecb
33bdcb9
f16775a
c56ceff
39b2f82
98346d3
4076ce8
57d7506
6937a17
b19e402
83b1a8b
2057612
8fe9cf7
4e9a651
fb3c953
c1bf911
0d49772
c9fc66a
e6bd72c
a01e439
4c0b60a
07be96e
3281245
b47d0d8
55913bc
a92737a
89298cf
1a5bf26
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,10 +46,6 @@ const pages = { | |
| }, | ||
| Badge: 'Badge', | ||
| Banner: 'Banner', | ||
| BottomNavigation: { | ||
| BottomNavigation: 'BottomNavigation/BottomNavigation', | ||
| BottomNavigationBar: 'BottomNavigation/BottomNavigationBar', | ||
| }, | ||
| Button: { | ||
| Button: 'Button/Button', | ||
| }, | ||
|
|
@@ -115,6 +111,9 @@ const pages = { | |
| MenuItem: 'Menu/MenuItem', | ||
| }, | ||
| Modal: 'Modal', | ||
| NavigationBar: { | ||
| NavigationBar: 'NavigationBar/NavigationBar', | ||
| }, | ||
|
Comment on lines
+114
to
+116
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The page title is now There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done 👌 both keys are |
||
| Portal: { | ||
| Portal: { | ||
| source: 'Portal/Portal', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need one more docs change -
docs/6.x/docs/guides/bottom-navigation.mdstill importsBottomNavigationand renders it, which is what this PR removes right? I think we should either rewrite it to include the newNavigationBaror drop it completely and point at at the migration entry.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done