Repository navigation
fix(fab)!: align MD3 variants and interaction states #5110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
likevy
wants to merge
20
commits into
callstack:main
Choose a base branch
from
likevy:fix/fab-md3-spec-accuracy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+637
−81
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8beab93
fix(fab): align MD3 variants and interaction states
likevy 2b290b0
fix(fab): address review feedback
likevy 968b711
fix(fab): skip hidden focus restoration targets
likevy 3a9c585
fix(fab): remove the branded variant
likevy 2c5d495
docs(fab): show how to keep the surface look after migrating
likevy ea12e01
refactor(fab): drop the redundant document check
likevy 0bd1016
fix(fab): name the menu trigger in the example
likevy 240d5be
docs(fab): format the migration snippet and table
likevy e9dace0
fix(fab): restore focus only after keyboard focus
likevy 0aefeb3
test(fab): name the disabled FAB test after its behavior
likevy 86ef160
test(fab): cover the press guard on a hidden FAB
likevy e881eca
test(fab): cover focus restoration when a FAB hides on web
likevy b9c67a4
test(fab): compare elevation between interaction states
likevy 79a3c5f
test(fab): check that focus alone keeps the resting elevation
likevy 76b2bfa
test(fab): pin the direction of the hover elevation
likevy fb7e14a
test(fab): cover the blur fallback when focus can't move back
likevy 5ad44a7
docs(fab): import useTheme from paper in the surface snippet
likevy de315af
docs(fab): note that explicit v5 variants still type-check
likevy 89a91a7
fix(fab): type the touchable ref for React Native 0.88
likevy 2c6a466
test(fab): type the FAB test refs for React Native 0.88
likevy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.