Repository navigation
fix(fab): expose expanded state on the FAB.Menu trigger - #5151
Open
Ganeshguru5 wants to merge 3 commits into
Open
Ganeshguru5 wants to merge 3 commits into
Ganeshguru5 wants to merge 3 commits into
Conversation
The trigger FAB toggles the menu but never set aria-expanded, so assistive technology announced it as a plain button with no open or closed state. Forward `expanded` to Shell, which already passes aria-expanded through to the interactive control. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Found potential problems with the pull request:
|
MikitasK
approved these changes
Nov 2, 2026
MikitasK
left a comment
MikitasK
left a comment
There was a problem hiding this comment.
good job 👍
could we just attach short before/after TalkBack + VoiceOver clips of the trigger? nothing else shows this state - Android exposes it as "expand/collapse" action, iOS only says "expanded" when open
Without onPress the closed trigger renders disabled, so the collapsed check ran against a disabled control. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
FAB.Menutrigger opens and closes the menu but never exposes whether it is open, so screen readers announce a plain "button".Shellalready forwardsaria-expanded;Menujust wasn't passing it.Related issue
No existing issue. Same kind of fix as #5148 for
Button. #5110 also editsMenu.tsx, so I can rebase after it.Screenshots / Videos
Web:
aria-expandedwas absent; it's now"false"when closed and"true"when open.TalkBack and VoiceOver before/after clips: to be added.
Test plan
Checked on web only so far.
🤖 Generated with Claude Code