fix: include event id in expired and rate-limited rejection logs - #735
Open
Ferryx349 wants to merge 1 commit into
Open
fix: include event id in expired and rate-limited rejection logs#735Ferryx349 wants to merge 1 commit into
Ferryx349 wants to merge 1 commit into
Conversation
Pass event.id to the logger for expired and rate-limited rejections so operators see the actual event id instead of a literal %s placeholder. Fixes cameri#723 Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 654c977 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
coverage: 70.692% (+0.008%) from 70.684% — Ferryx349:fix/723-rejection-logger-event-id into cameri:main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two rejection log calls in
EventMessageHandlerused%splaceholders without passingevent.id, so logs showed a literal%sinstead of the event id for expired and rate-limited rejections.Related Issue
Fixes #723
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: