Close unused stdin for noninteractive local commands - #579
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
OskarEichler
force-pushed
the
codex/close-unused-local-stdin
branch
from
August 30, 2026 10:38
8360081 to
29ea27d
Compare
OskarEichler
force-pushed
the
codex/close-unused-local-stdin
branch
from
August 30, 2026 12:37
29ea27d to
035e6f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close child stdin immediately when a local command has no interaction handler. Commands such as
catotherwise wait indefinitely for EOF even though SSHKit has no producer for their input. Interaction-handler commands keep the stream open.A bounded dual-Ruby local-process model reproduces the hang before and clean EOF after; interaction cases remain green. The unchanged suite passes 218 tests /3,411 assertions. No repository tests were changed.