Repository navigation
Conversation
AWS Emulator is a local program, published by AWS, which serves the AWS APIs and keeps the resources in memory. Tests can use it instead of an AWS account. https://github.com/aws/aws-emulator AWS publishes it for Linux only, as RPM and Debian packages. The new target downloads the Debian package, checks its SHA256 and unpacks the binary without installing the package. It uses dpkg-deb where that exists, because our CI image has no xz command, and ar and tar elsewhere. On other systems the tool is left out of the non-go-tools and tools targets, and asking for it directly fails with a clear message. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Richard Wall <richard@the-moon.net>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
wallrj
added a commit
to wallrj/cert-manager
that referenced
this pull request
Nov 12, 2026
The tools module is temporarily taken from the branch of cert-manager/makefile-modules#803, which adds the aws-emulator tool. That branch is based on the latest makefile-modules, so this also updates the vendored Go to 1.27.4 and a few other tools. On Linux, make test and make test-ci now download the emulator and set AWS_EMULATOR to its path. The tests use that path, so they cannot be skipped by accident in CI. AWS publishes the emulator for Linux only, so the tests are still skipped on other systems. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Richard Wall <richard@the-moon.net>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Richard Wall <richard@the-moon.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
aws-emulatorto the tools module, so that projects can run tests against a local copy of the AWS APIs instead of an AWS account.AWS Emulator is published by AWS. It was announced on 11 November 2026.
Why?
cert-manager tests its Route 53 DNS-01 provider by replaying canned XML. With the emulator, the tests can sign real requests and read the records back. cert-manager/cert-manager#9586 uses this tool. It points
klone.yamlat this branch so that the tests run in CI.What does the target do?
make _bin/tools/aws-emulatordownloads the Debian package fromdownloads.aws.com, checks its SHA256 and unpacks the binary without installing the package.dpkg-debwhere that exists. Ourmake-dindCI image hasdpkg-debandar, but noxz.arandtar.What happens on macOS?
AWS publishes the emulator for Linux only. On other systems:
make non-go-toolsandmake toolsleave it out, solearn-tools-shasstill works.make _bin/tools/aws-emulatorfails with "aws-emulator is only published for Linux".What I tested
make _bin/tools/aws-emulatoron Fedora, amd64 (arandtar)make-dind:20260529-7f372af-trixie(dpkg-deb)HOST_ARCH=arm64HOST_OS=darwin, direct targetHOST_OS=darwin,make -n non-go-toolsThings to weigh before merging
v1.0.322and the package is1.0.322-1. I checked that this mapping holds for this one version only.[Claude Fable 5.2]