fix(export/print): iframe style transfer and stabilize peak label positioning and sizing - #4328
Merged
Conversation
hamed-musallam
commented
Aug 26, 2026
hamed-musallam
commented
Member
- replace duplicated style-copy logic with shared transferStylesToDocument helper.
- safely skip inaccessible stylesheet rules (SecurityError/NotAllowedError) instead of crashing.
- fix peak label size and Y by measuring SVG height with getBBox.
Deploying nmrium with
|
| Latest commit: |
f2a4504
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ad80a98b.nmrium.pages.dev |
| Branch Preview URL: | https://fix-print-export.nmrium.pages.dev |
hamed-musallam
force-pushed
the
fix-print-export
branch
2 times, most recently
from
August 26, 2026 09:41
eb0836f to
116b329
Compare
…itioning and sizing - replace duplicated style-copy logic with shared transferStylesToDocument helper. - safely skip inaccessible stylesheets rules (SecurityError/NotAllowedError) instead of crashing. - fix peak label size and Y by measuring SVG height with getBBox.
hamed-musallam
force-pushed
the
fix-print-export
branch
from
August 26, 2026 09:43
116b329 to
f2a4504
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.