fix: render secondary ticks only between primary ticks - #4330
Merged
Conversation
hamed-musallam
commented
Aug 26, 2026
hamed-musallam
commented
Member
- Remove edge secondary tick rendering that could appear outside axis boundaries.
- Compute secondary tick positions as midpoints between primary ticks.
- Remove edge secondary tick rendering that could appear outside axis boundaries. - Compute secondary tick positions as midpoints between primary ticks.
Deploying nmrium with
|
| Latest commit: |
0ca272c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://71112612.nmrium.pages.dev |
| Branch Preview URL: | https://fix-seconday-ticks.nmrium.pages.dev |
hamed-musallam
force-pushed
the
fix-seconday-ticks
branch
from
August 26, 2026 14:00
39068fe to
0ca272c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.