Skip to content

fix(auth): token validation and direct-download safeguards - #11

Closed
chenrui333 wants to merge 1 commit into
review-base/upstream-devfrom
fix/token-validation-safeguards
Closed

chenrui333 wants to merge 1 commit into
review-base/upstream-devfrom
fix/token-validation-safeguards

Conversation

@chenrui333

Copy link
Copy Markdown
Owner

Review copy of a proposed upstream change, based on falcondev-oss/github-actions-cache-server@dev (6ae06c2). Upstream accepts pull requests from collaborators only, so this branch is offered through an upstream issue.

Direct downloads hand the runner a signed storage URL whose only gate is the Actions runtime token. This adds the missing safeguards around that token:

  • refuse ENABLE_DIRECT_DOWNLOADS with SKIP_TOKEN_VALIDATION at startup unless an explicit UNSAFE_… override is set;
  • require exp;
  • optional ACTIONS_TOKEN_AUDIENCE;
  • schema-check ac and treat permissions as read/write bit flags;
  • log only the jose error code and claim, not the decoded claims;
  • DIRECT_DOWNLOAD_URL_TTL_SECONDS (default 600, unchanged), with the reader lease outliving the URL.

Tests: pnpm test:run sqlite+filesystem 97 passed / 5 skipped; postgres and mysql 47 passed / 1 skipped each.

A direct-download URL is a bearer credential for the stored object, and
the only gate in front of it is the token's `repository_id` and `ac`
claims. With SKIP_TOKEN_VALIDATION those claims are never verified, so
the server now refuses to start with ENABLE_DIRECT_DOWNLOADS and
SKIP_TOKEN_VALIDATION together, unless
UNSAFE_ALLOW_DIRECT_DOWNLOADS_WITHOUT_TOKEN_VALIDATION is set for local
testing.

- DIRECT_DOWNLOAD_URL_TTL_SECONDS (1-3600, default 600, the lifetime
  signed URLs had so far) sets the signed URL lifetime. The reader lease
  outlives the URL by a fixed margin, since storage authenticates a GET
  only when it starts.
- Token verification requires `exp` (jose checks it only when present);
  the optional ACTIONS_TOKEN_AUDIENCE pins `aud`, and a value that lists
  no audience stops startup instead of disabling the check.
- Token rejections report the jose error code and claim name instead of
  attaching the jose error, which carries the decoded claims, to the
  logged error.
- `ac` scopes are schema-checked and treated as bit flags (read = 1,
  write = 2): lookups use only readable scopes, uploads and finalizes
  only writable ones.

The tests run a second server against a local OIDC issuer (discovery
and JWKS), covering key rotation, a JWKS outage, pull request scopes and
the signed URL lifetime on S3, GCS and Azure Blob.

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T20:44:53.439801Z 2b04a8b Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 2b04a8b3b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chenrui333

Copy link
Copy Markdown
Owner Author

Superseded by upstream v10.0.0 (falcondev-oss#309).

@chenrui333 chenrui333 closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant