Repository navigation
fix(auth): token validation and direct-download safeguards - #11
Closed
chenrui333 wants to merge 1 commit into
Closed
chenrui333 wants to merge 1 commit into
chenrui333 wants to merge 1 commit into
Conversation
A direct-download URL is a bearer credential for the stored object, and the only gate in front of it is the token's `repository_id` and `ac` claims. With SKIP_TOKEN_VALIDATION those claims are never verified, so the server now refuses to start with ENABLE_DIRECT_DOWNLOADS and SKIP_TOKEN_VALIDATION together, unless UNSAFE_ALLOW_DIRECT_DOWNLOADS_WITHOUT_TOKEN_VALIDATION is set for local testing. - DIRECT_DOWNLOAD_URL_TTL_SECONDS (1-3600, default 600, the lifetime signed URLs had so far) sets the signed URL lifetime. The reader lease outlives the URL by a fixed margin, since storage authenticates a GET only when it starts. - Token verification requires `exp` (jose checks it only when present); the optional ACTIONS_TOKEN_AUDIENCE pins `aud`, and a value that lists no audience stops startup instead of disabling the check. - Token rejections report the jose error code and claim name instead of attaching the jose error, which carries the decoded claims, to the logged error. - `ac` scopes are schema-checked and treated as bit flags (read = 1, write = 2): lookups use only readable scopes, uploads and finalizes only writable ones. The tests run a second server against a local OIDC issuer (discovery and JWKS), covering key rotation, a JWKS outage, pull request scopes and the signed URL lifetime on S3, GCS and Azure Blob. Signed-off-by: Rui Chen <rui@chenrui.dev>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Oct 24, 2026
Owner
Author
|
Superseded by upstream v10.0.0 (falcondev-oss#309). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct downloads hand the runner a signed storage URL whose only gate is the Actions runtime token. This adds the missing safeguards around that token:
ENABLE_DIRECT_DOWNLOADSwithSKIP_TOKEN_VALIDATIONat startup unless an explicitUNSAFE_…override is set;exp;ACTIONS_TOKEN_AUDIENCE;acand treat permissions as read/write bit flags;DIRECT_DOWNLOAD_URL_TTL_SECONDS(default 600, unchanged), with the reader lease outliving the URL.Tests:
pnpm test:runsqlite+filesystem 97 passed / 5 skipped; postgres and mysql 47 passed / 1 skipped each.