Repository navigation
A driver configured into a mounted instance learns about its friends - #78
Merged
Merged
Conversation
A driver added after the mount (a mount point's cfg/drivers, loaded by
devscan) was announced to the members of its friends group that already
existed, but never heard of them: the codec of the STM32F746G-DISCO, which
is configured after the touch panel's I2C bus, found no bus friend
("I2C bus friend is not ready") and /dev/wm8994 failed. At the initial mount
every driver gets the notifications of the others; do the same for a driver
added later.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
JohnAmadis
approved these changes
Oct 26, 2026
JohnAmadis
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A driver added after the mount (a mount point's
cfg/drivers, loaded bydevscan) was announced to the already existing members of its friends group, but never heard of them. On the STM32F746G-DISCO the codec (configured after the touch panel's I2C bus) reportedI2C bus friend is not ready, and/dev/wm8994failed.Change
At the initial mount every driver gets the notifications of the others. A driver configured into an already-mounted instance now gets the same notifications for the members of its group (
notify_node_about_friends).Testing
Checked on the board: with
driversloaded from/ext/cfg/drivers,/dev/wm8994,/dev/touchanddmaudio@wm8994come up. No unit test added (the mock driver has nofriend_changed).🤖 Generated with Claude Code