Repository navigation
Keep optional package resources optional with package-dir - #338
Merged
Merged
Conversation
JohnAmadis
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing existing release packages with
--package-dirfailed when their.dmrdeclared optional documentation that was absent from the archive (observed with dmhaman in a dmod-boot build). Previously these resources were warned about and skipped.Restore that behavior for missing optional resources while retaining failures for explicitly requested licenses and module binaries. Errors writing resources still fail installation. Extend the package-directory integration fixture with an absent optional resource.
Validation: native dmf-get build and the full dmf-get integration suite passed. The dmod-boot module downloads also completed with this fix.