Repository navigation
feat(python): generate the EQL type markers from the catalog (#1385) #1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+1,736
−50
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,20 @@ | ||
| """Searchable encryption for Python, over the CipherStash Stack engine. | ||
|
|
||
| Walking skeleton. The package loads its native extension, ``_engine``, and | ||
| exposes two facts about the build. Nothing encrypts yet. | ||
| Walking skeleton. The package loads its native extension, ``_engine``, exposes | ||
| two facts about the build, and exports the markers a model's fields are | ||
| declared with. Nothing encrypts yet. | ||
| """ | ||
|
|
||
| from stackencrypt import _engine | ||
| from stackencrypt import _engine, _eql | ||
| # The markers for the EQL types the engine produces today. `_eql.__all__` | ||
| # lists them; a marker the engine cannot produce yet stays in `_eql` only. | ||
| from stackencrypt._eql import * # noqa: F403 | ||
| from stackencrypt._markers import Ignore, Passthrough | ||
|
|
||
| # The distribution's version, and the commit of the engine it was built from. | ||
| __version__: str | ||
| __engine__: str | ||
| __version__, __engine__ = _engine.build_info() | ||
|
|
||
| __all__ = ["__engine__", "__version__"] | ||
| __all__ = ["Ignore", "Passthrough", "__engine__", "__version__"] | ||
| __all__ += _eql.__all__ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: no repo test checks that
tests-python.ymlstill runspy_eql_parity.Impact: This step is the only check that runs when someone edits
_eql.pyby hand.test-eql.ymldoes not start on a change underlanguages/python. If a later edit removes or renames this step, the Python workflow still passes. A hand edit to_eql.pythen merges with no failing check.Evidence:
scripts/__tests__/python-ci.test.mjschecks the path filter and the matrices. No test underscripts/__tests__namespy_eql_parity.Fix: Add a case to
python-ci.test.mjsthat reads the workflow and expects exactly onerunstep containingcargo test,--locked,-p eql-codegenand--test py_eql_parity.Found by 1 model: claude