fix(objectstore): guard credential secret against unsafe args[0] indexing and reject extra args - #602
Open
karthik120710 wants to merge 1 commit into
Open
fix(objectstore): guard credential secret against unsafe args[0] indexing and reject extra args#602karthik120710 wants to merge 1 commit into
credential secret against unsafe args[0] indexing and reject extra args#602karthik120710 wants to merge 1 commit into
Conversation
… command argument handling Signed-off-by: Karthik Rajan <karthikrajanmr@gmail.com>
Author
|
hi @giornetta @hlts2 i have fix the potential bug and added test case to verify my changes can u review my pr. |
Member
Thanks for the PR! I'll review it as soon as possible 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #601
objectStoreCredentialSecretCmdresolved its access key with: