Repository navigation
Forward compressed API request bodies unchanged - #177
Merged
Merged
Conversation
The Notion client now gzips event batches sent to /api/v3/etClient. The worker read every API body as text and dropped Content-Encoding, so Notion rejected them with 400 invalid_json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #171.
The Notion client now sends gzip-compressed event batches to
/api/v3/etClient(Content-Encoding: gzip). The worker read every/api/request body withrequest.text()and did not forwardContent-Encoding, so the bytes were corrupted and Notion answered400 invalid_json. This made the daily render check fail with400 /api/v3/etClient.buildApiHeadersforwardscontent-encoding/api/bodies are forwarded as raw bytes; uncompressed JSON bodies keep the space-domain swapVerification
Ran
scripts/render-check.mjslocally against the live test page with request logging:/api/v3/etClientrequest returned400 {"code":"invalid_json"}/api/v3/etClientrequests (gzipped and plain) return200,no errorspassesnpm run buildpassesThe remaining
NOTIONresults (database views/rows, item click, navigation) also fail on notion.site itself, so they are not Worknot regressions.