Repository navigation
Fix admonition titles rendering as literal text (83 on 48 pages) - #147
Merged
Merged
Conversation
future.v4 turns off mdx1Compat.admonitions, so 83 admonitions on 48 pages written as `:::danger Title` showed the title as literal text, including the approval/sandbox safety warnings. Turn the compat flag back on; the build now has no literal ':::' admonition lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
future.v4: trueturns offmarkdown.mdx1Compat.admonitions. As a result, 83 admonitions on 48 pages written as:::danger Titleshowed the title as literal text, for example:::danger Commands run without asking by defaulton basic-usage. That includes the approval and sandbox safety warnings from #126.This turns the compat flag back on. After the build, no HTML page contains a literal
:::type Titleline, and basic-usage renders the heading "Commands run without asking by default". The 1-line config change was chosen over rewriting 83 admonitions to:::type[Title]; the per-page conversion can follow later if we want to drop the compat flag.Found by the security-timeline work in #146.