fix(expo): fire AuthView onDismiss when isDismissible is false on iOS - #9501
Draft
wobsoriano wants to merge 2 commits into
Draft
fix(expo): fire AuthView onDismiss when isDismissible is false on iOS#9501wobsoriano wants to merge 2 commits into
wobsoriano wants to merge 2 commits into
Conversation
The iOS bridge only reported a dismissal when the view was dismissible, so a non-dismissible AuthView never told JS the auth flow had finished and an app-owned modal stayed open after sign-in. Android already fires onAuthComplete regardless. Wires the new clerkAuthCompletionAction SPI from clerk-ios into the hosted auth view, ungated by dismissibility. The detach path keeps its dismissible check, since a non-dismissible view never self-dismisses and a detach there is the host tearing the view down.
🦋 Changeset detectedLatest commit: dbc2072 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Constructing ClerkAuthCompletionAction, which is @mainactor, from a nonisolated context failed to compile. The neighbouring makeUserProfileViewController was already annotated, and the caller in ClerkNativeViewHost is main-actor isolated via UIView, so this brings the two factory methods back in line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The iOS bridge only reported a dismissal when the view was dismissible, so a non-dismissible AuthView never told JS the auth flow had finished and an app-owned modal stayed open after sign-in. Android already fires onAuthComplete regardless.
Wires the new
clerkAuthCompletionActionSPI from clerk-ios into the hosted auth view, ungated by dismissibility. The detach path keeps its dismissible check, since a non-dismissible view never self-dismisses and a detach there is the host tearing the view down.Part of MOBILE-625
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change