Repository navigation
feat(react-form): preserve inline edit lifecycle and validation updates - #256
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original request
Support blur validation and rejected inline edits in the headless form package, with no imposed UI or changes to existing defaults.
What changed
validateOnBlur: immediately validate current values, cancel pending debounce, and touch only the blurred field.FormSubmitOptions.onInvalid(result)inside the managed submission lock.refreshValidationRulesfor changed bounds/messages with a fixed field model. Preserve raw values, baselines, dirty/touched state and suppress stale validation/submission callbacks.Reasoning
Applications can retain their existing controls and decide whether rejected inline edits restore a saved baseline. The package owns validation timing, duplicate protection and stale-result handling. Both additions are optional, preserving existing behavior.
Blog post
Skipped: internal headless lifecycle integration. Public contracts are documented in the package README and JSDoc.
Screenshots / preview evidence
No visual surface or configured preview is changed by this library PR. DOM/hook tests verify behavior without a UI dependency; consumer visual acceptance is separate.
Validation
npm run lint: pass.npm run build: all 24 package builds pass.npm run test: 5,396 tests across 303 files pass; no type errors.