Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ jobs:
timeout-minutes: 20 # on a successful run, runs in 8 minutes
container:
# !rust-toolchain-sync
image: rust:1.97.1
image: rust:1.98.1
options: --privileged
# disable until we fix the benchmarks
if: false
Expand Down
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ debug = true
version = "2.16.0"
edition = "2024"
# update rust-toolchain.toml too!
rust-version = "1.97"
rust-version = "1.98"

[workspace.dependencies]
spacetimedb = { path = "crates/bindings", version = "=2.16.0" }
Expand Down Expand Up @@ -268,7 +268,6 @@ indicatif = "0.17"
insta = { version = "1.21.0", features = ["toml", "filters"] }
is-terminal = "0.4"
itertools = "0.12"
itoa = "1"
json5 = "0.4"
jsonwebtoken = { version = "11.0.0", features = ["rust_crypto"] }
junction = "1"
Expand Down
2 changes: 1 addition & 1 deletion crates/bench/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# See the README for commands to run.

# !rust-toolchain-sync
FROM rust:1.97.1
FROM rust:1.98.1
# Refresh OS certificate roots to distrust the compromised eMudhra CAs.
RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates && rm -rf /var/lib/apt/lists/*
# rustup has its own CA bundle; 1.29.2+ distrusts the compromised eMudhra CAs.
Expand Down
1 change: 0 additions & 1 deletion crates/paths/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ description = "The spacetimedb directory structure, represented as a type hierar
anyhow.workspace = true
chrono = { workspace = true, features = ["now"] }
fs2.workspace = true
itoa.workspace = true
serde.workspace = true
tempfile.workspace = true
thiserror.workspace = true
Expand Down
4 changes: 2 additions & 2 deletions crates/paths/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ pub(crate) trait PathBufExt: BorrowMut<PathBuf> + Sized {
self.borrow_mut().set_extension(std::env::consts::EXE_EXTENSION);
self
}
fn joined_int<I: itoa::Integer>(self, path_seg: I) -> Self {
self.joined(itoa::Buffer::new().format(path_seg))
fn joined_int(self, path_seg: u64) -> Self {
self.joined(path_seg.format_into(&mut core::fmt::NumBuffer::new()))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this change to me real quick?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the itoa crate anymore in order to format into a local buffer, std supports the operation natively.

}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/standalone/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ ARG CARGO_PROFILE=release


# !rust-toolchain-sync
FROM rust:1.97.1 AS chef
FROM rust:1.98.1 AS chef
# Refresh OS certificate roots to distrust the compromised eMudhra CAs.
RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates && rm -rf /var/lib/apt/lists/*
# rustup has its own CA bundle; 1.29.2+ distrusts the compromised eMudhra CAs.
Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[toolchain]
# run ./tools/rust-toolchain-sync.sh when you change the channel!
# also consider changing the rust-version in Cargo.toml
channel = "1.97.1"
channel = "1.98.1"
profile = "default"
targets = ["wasm32-unknown-unknown"]
components = ["rust-src"]
Loading