feat(AIENG-625): Add support for SMART_TESTS_MATRIX environment varia… - #1360
Merged
Conversation
…ble to send flavors in subset payload
psakthivel04
force-pushed
the
feat/AIENG-625-flavors
branch
from
August 17, 2026 06:27
6ea078b to
21aa9d6
Compare
Konboi
reviewed
Aug 25, 2026
| LEGACY_TOKEN_KEY = "LAUNCHABLE_TOKEN" | ||
|
|
||
| # GitHub Actions matrix as JSON, e.g. SMART_TESTS_MATRIX='{"shard":"1","os":"ubuntu"}' | ||
| MATRIX_KEY = "SMART_TESTS_MATRIX" |
Contributor
There was a problem hiding this comment.
Since “matrix” in Smart Tests usually refers to flavors, SMART_TEST_MATRIX could be a little confusing.
It’s a bit longer, but wouldn’t SMART_TEST_GITHUB_ACTIONS_MATRIX or GITHUB_ACTIONS_MATRIX be clearer?
What do you think?
…ble to send flavors in subset payload
Konboi
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for passing environment-specific "flavors" to the subset command via a new environment variable, and includes tests to verify the new behavior. The main changes introduce reading a JSON matrix from the environment, incorporating it into the payload, and ensuring robust handling and testing of this feature.
Support for matrix flavors via environment variable:
SMART_TESTS_MATRIX(imported asMATRIX_KEY), which is expected to contain a JSON object describing test matrix flavors (e.g. shard, OS). (smart_tests/utils/env_keys.py,smart_tests/commands/subset.py) [1] [2]subsetcommand to parse theSMART_TESTS_MATRIXenvironment variable, extract its contents into aflavorsdictionary, and include it in the payload sent to the server if present. (smart_tests/commands/subset.py) [1] [2]Testing and validation:
SMART_TESTS_MATRIXenvironment variable is set, its contents are correctly sent asflavorsin the payload, and that noflavorsfield is sent when the variable is absent. (tests/commands/test_subset.py)…ble to send flavors in subset payload