refactor: drop the @ts-ignore from ValidationError - #650
Open
kahirokunn wants to merge 1 commit into
Open
Conversation
Author
|
Hi ✋ would you mind taking a look when you have a chance? Thank you 🙏 |
kahirokunn
force-pushed
the
validation-error-ts-ignore
branch
from
August 17, 2026 11:13
01ba484 to
8cd5a1b
Compare
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
kahirokunn
force-pushed
the
validation-error-ts-ignore
branch
from
August 17, 2026 11:41
8cd5a1b to
507ec01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove the
@ts-ignorefromValidationError.Description
Type the local error array as
Array<string | ErrorObject>so TypeScript can check thereduce()call without changing runtime behavior. Focused tests cover string, Ajv, and missing errors.