fix: defer committed inode stream reads (#115) - #117
Merged
Conversation
ReadableStream's default queue can pull a chunk as soon as the stream is created. Use a zero high water mark so blob reads begin only when a consumer requests data across both supported stream runtimes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @aron-cf
Closes #115
readCommittedFileByInode()inpackages/dofs/src/fs/readFile.ts:159used the defaultReadableStreamqueue. Its high water mark lets the Workers runtime pull the first chunk while the stream is being created, so the regression test observed one blob query before its first read.This sets the stream's high water mark to zero. Blob reads now start only when the consumer asks for data, which preserves the intended lazy behavior and is the smallest change that makes Node and Workers use the same scheduling contract.
Testing
The existing
readFile.test.tsregression reproduced the Workers failure before this change and passed afterward (15 tests).npm test --workspace @cloudflare/dofspassed all 567 Node tests,npm run test:workers --workspace @cloudflare/dofspassed all 554 Workers tests, and the package build, typecheck, formatting, and lint checks passed.Demo
No temporary deployment: this changes internal stream pull timing and has no click-visible runtime surface to demo.
🤖 generated by the pr-agent — please review carefully