Add missing valid values to extra_access_log_fields validation - #583
Open
lodener wants to merge 1 commit into
Open
Add missing valid values to extra_access_log_fields validation#583lodener wants to merge 1 commit into
lodener wants to merge 1 commit into
Conversation
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
router.logging.extra_access_log_fieldsproperty in the gorouter spec documents these available fields:backend_time, caller_cf_app, caller_cf_org, caller_cf_space, dial_time, dns_time, failed_attempts, failed_attempts_time, local_address, route_policy, tls_sni, tls_timeHowever, the validation list in
jobs/gorouter/templates/gorouter.yml.erbonly allows a subset:backend_time, dial_time, dns_time, failed_attempts, failed_attempts_time, local_address, tls_timeAs a result, setting any of
caller_cf_app,caller_cf_org,caller_cf_space,route_policyortls_sni(as documented in the spec) makes template rendering fail with:router.logging.extra_access_log_fields ([...]) contains invalid values, valid are [...]This PR adds the five missing values to the validation list so the template accepts everything the spec documents. Only the validation list changed; the values are passed through to gorouter as before.
Backward Compatibility
Breaking Change? No
This only widens the set of accepted values. Deployments that render today keep rendering identically, and deployments that previously failed on documented field names will now succeed.