Fix control styles on the gallery settings page - #1238
Open
utkarshcloudinary wants to merge 1 commit into
Open
Conversation
The Layout control and the other custom controls on the gallery settings page showed the default browser button style. The controls did not get their styles. The styles are in gallery.scss. Only the block editor imported this file. The settings page app did not import it, and the enqueued styles did not include it. To correct this: - Import gallery.scss in the settings page app. - Enqueue the built css/gallery.css on the settings page. Commit 0b0b520 removed the gallery.scss import from the settings page app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Layout control and the other custom controls on the gallery settings page showed the default browser button style. The controls did not get their styles.
The styles are in
gallery.scss. Only the block editor imported this file. The settings page app did not import it, and the enqueued styles did not include it.Approach
gallery.scssin the settings page app (src/js/components/settings-gallery.js). The build makescss/gallery.css.css/gallery.csson the gallery settings page (php/media/class-gallery.php).Commit 0b0b520 removed the
gallery.scssimport from the settings page app.QA notes