Repository navigation
fix(postgis): build from master with address_standardizer and tiger geocoder - #171
Merged
Merged
Conversation
…ocoder PostGIS 3.7.0 removed address_standardizer and postgis_tiger_geocoder from the main repository. With the base images on the CNPG side now shipping 3.7.0, the upgrade tests were trying to upgrade from 3.6 to 3.7.0, which cannot work. Go back to building PostGIS from master (reverting the stable-3.6 pin from #128) and build the two extensions from their new standalone repositories. Also add git-clone-retry.sh and use it for the clones from non-GitHub remotes (git.postgresql.org, git.osgeo.org), as they can sometimes time out from GitHub runners. The script and build-deps.txt are now bind-mounted into the RUN steps instead of copied, so they don't end up in the image. Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
NiccoloFei
force-pushed
the
fix/postgis-main
branch
from
November 12, 2026 16:28
7e79d45 to
941dbcd
Compare
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
litaocdl
approved these changes
Nov 13, 2026
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
NiccoloFei
force-pushed
the
fix/postgis-main
branch
from
November 16, 2026 16:33
3c92ad3 to
d10fa9d
Compare
Contributor
Author
|
A working E2E run https://github.com/cloudnative-pg/postgres-trunk-containers/actions/runs/43910584071 |
The runtime libraries are pinned by soname. If PGDG bumps one, the extensions link against the new version, the purge removes it, and the image breaks at runtime while the build stays green. Run ldd on the installed extension libraries after the purge and fail the build if a dependency is missing. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
force-pushed
the
fix/postgis-main
branch
from
November 17, 2026 08:20
08e94e0 to
435bf1d
Compare
mnencia
approved these changes
Nov 17, 2026
Five retries with a fixed 5 second delay all failed within 45 seconds when git.postgresql.org dropped connections. Use 15 seconds multiplied by the attempt number, so the script waits about 150 seconds in total before giving up. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
The build only needs the tip of the branch and its short commit hash. A shallow clone transfers far less data, which makes it faster and less exposed to connection drops from git.postgresql.org. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostGIS 3.7.0 removed
address_standardizerandpostgis_tiger_geocoderfrom the main repository.With the base images on the CNPG side now shipping 3.7.0, the upgrade tests were trying to upgrade from 3.7 to 3.6, which cannot work.
Go back to building PostGIS from master (reverting the
stable-3.6pin from #128) and build the two extensions from their new standalone repositories.address_standardizeris pinned tov3.7.0until there is an upgrade path from v3 to v4.Master needs newer GDAL libraries, so the PostGIS stage now enables the PGDG apt repository and installs
libgdal39from it. The repository is removed at the end of the stage. A finallddcheck fails the build if the purge removes a library the extensions link against.Also add
git-clone-retry.shand use it for the clones from non-GitHub remotes (git.postgresql.org,git.osgeo.org), as they can sometimes time out from GitHub runners.The script and
build-deps.txtare now bind-mounted into the RUN steps instead of copied, so they don't end up in the image.