Skip to content

fix issue #1732 #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlohse-mpi-sws wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −3
Open

fix issue #1732 #1733

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90b2ff2
fix issue #1732
jlohse-mpi-sws Oct 18, 2026
75f190e
prioritize contestant failure over controller failure
jlohse-mpi-sws Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cms/grading/tasktypes/interactive_keeper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,13 @@ def do_merge(a, b):
+ text[1:]
)
elif not evaluation_success_mgr:
outcome = 0.0
text = ["Controller failed"] + (controller_text if controller_text else [])
success = False
text = ["Controller failed"]
elif score is None:
success = False
text = ["Controller did not report a score"]
else:
outcome = score if score is not None else 0.0
outcome = score
text = controller_text

result = {
Expand Down
Loading