Repository navigation
chore(deps-dev): bump @antfu/eslint-config from 9.5.1 to 10.0.0 - #646
Conversation
dependabot
Bot
added
the
dependencies
|
Please add a kind label with |
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
build-test is red on this head and it is this diff's doing, not infrastructure: @antfu/eslint-config 10.0.0 enables the new antfu/reasonable-newline rule, and npm run lint now fails with dozens of errors across existing files (run 41220235157, job 124593075838 — e.g. "Items containing calls, functions, ternaries, complex spreads or non-empty nested objects/arrays should have line breaks between items" and "Objects with 4 or more properties on a line longer than 40 should have line breaks between items").
This is a major-version bump, so the code churn is expected — but Dependabot will not write the companion commit. For this to land, someone needs to push npx eslint --fix (the rule is auto-fixable) on this branch plus any manual leftovers, or pin the rule off in eslint.config if the repo doesn't want the reformat. Note charts/**/tests/*.yaml is in lint scope too, so check the fix doesn't fight the single-quote convention there.
Until that commit exists this PR cannot merge; recommend a maintainer (or the hive fix lane) adopts the branch rather than closing it.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
Bumps [@antfu/eslint-config](https://github.com/antfu/eslint-config) from 9.5.1 to 10.0.0. - [Release notes](https://github.com/antfu/eslint-config/releases) - [Commits](antfu/eslint-config@v9.5.1...v10.0.0) --- updated-dependencies: - dependency-name: "@antfu/eslint-config" dependency-version: 10.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
0162d61 to
4817e7f
Compare
reasonable-newline, new in 10, would re-wrap about 3700 one-line objects and calls; it stays off. The one prefer-type-error finding in meow.ts is deliberate: fetchCatImage retries a TypeError as a network failure, so a malformed 2xx must stay a plain Error. Signed-off-by: Jeffrey Sica <me@jeefy.dev>
There was a problem hiding this comment.
Read the tree at head ff0a65bf, not just the diff. This looks correct to me.
What I verified:
- The
build-testfailure on this PR is from the previous head (dependabot's4817e7f, run 41266113854):@antfu/eslint-config10 enablesantfu/reasonable-newline, which flagged hundreds of existing one-line objects/calls. The follow-up commitff0a65bfaddresses exactly that by turning the rule off ineslint.config.mjs:16-20instead of re-wrapping the whole tree — a reasonable call that keeps the diff reviewable. CI is re-running on the new head. - The
eslint-disable-next-line unicorn/prefer-type-erroratsrc/issueComment/meow.ts:121is justified, not a suppression of a real issue:fetchCatImageretries anyTypeErroras a network failure (src/issueComment/meow.ts:92-97), andparseCatImageis invoked inside thattry(meow.ts:77). Switching the malformed-2xx throw toTypeErrorwould make the retry loop re-request a bad payload up tomaxAttemptstimes — the plainErroris load-bearing, and the inline comment says so. dist/index.jsmatches thesrc/issueComment/meow.tschange (same comment + disable at the bundledparseCatImage), so the committed bundle was rebuilt, not hand-edited out of sync.
No findings. Once the re-run on ff0a65bf is green this is a routine dev-dependency bump plus the minimal config accommodation for its one breaking rule.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
Bumps @antfu/eslint-config from 9.5.1 to 10.0.0.
Release notes
Sourced from @antfu/eslint-config's releases.
Commits
54bfe6achore: release v10.0.0277df23chore: upgrade deps to latest majors55ed64bfeat!: upgrade deps, enableantfu/reasonable-newlineand stabilize `consist...