Repository navigation
fix(persistence): store the viewer's can_pin permission - #1897
Merged
Merged
Conversation
#1884 parsed ViewerState.Permissions.can_pin but never saved it, so every chat read it back as false. Add chat_metadata.can_pin (DB v51) and re-arm viewer_state_version on upgrade, as can_edit and can_invite did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1884 parsed
ViewerState.Permissions.can_pinintocanPinbut never stored it, so every chat read backcanPin = falsefromchat_metadataand no client UI could offer Pin. Found while building the pin menu (#1898): the server sentcan_pinfor a DM, and the row had no column for it.50 → 51(AutoMigration):chat_metadata.can_pin, written and cleared alongsidecan_edit,can_inviteand the moderation flags inChatMetadataDao.Migration50To51resetsviewer_state_version, the same way thecan_editandcan_invitemigrations did. Otherwise rows already at the current viewer-state version would keepcan_pin = 0until that version changes.ChatEntityMappermaps the flag both ways;ChatEntityMapperTestadds a round-trip case.