Repository navigation
Conversation
The desktop app showed the Java icon in the Dock and no icon in the window title bar or taskbar. The icons are rendered from the iOS app's Icon Composer file (Flipcash/Supporting Files/AppIcon.icon) with ictool, so desktop matches the phone apps: - icons/Flipcash.icns: macOS, body at 824 of 1024 on Apple's icon grid - icons/Flipcash.ico: Windows, 16 to 256 px - icons/Flipcash.png: Linux, 512 px nativeDistributions now uses all three. At runtime the window gets the icon, and on macOS the Dock gets it through java.awt.Taskbar, because `gradle run` has no app bundle to read it from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop app showed the Java icon in the Dock and no icon in the window title bar or taskbar.
The icons are rendered with
ictoolfrom the iOS app's Icon Composer file (Flipcash/Supporting Files/AppIcon.iconin code-ios-app), so desktop matches the phone apps:icons/Flipcash.icnsicons/Flipcash.icoicons/Flipcash.pngnativeDistributionsuses all three. At runtime the window gets the icon throughWindow(icon = …). On macOS the Dock gets it throughjava.awt.Taskbar, becausegradle runhas no app bundle to read the icon from.#1920 touches the same lines in
Main.kt(window state and chrome). The conflict is additive: keep both sides.