Repository navigation
feat(analytics): count Send Back taps and returns - #1952
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catalogue changes for Send Back, which lets the receiver of a DM's opening payment return it from the bubble. Spec: orchestrator
docs/specs/chat-send-back.md(Analytics section).Events
Sent Cash(newContextvalueSend Back)Recipient Countis not sent.Send Back: Tapped(new)Has Balance: false when the receiver's balance of the payment's token is too lowTogether they give the funnel: offers tapped, blocked by balance (
Has Balance= false), sent (Sent Cash,Context= Send Back, Success).Neither event carries the intent ID, chat ID or message ID.
Where to send it
ChatViewModelin the messenger feature, on the Send Back tap (Send Back: Tapped) and in the return submit path (Sent Cash). Wired in the follow-up feature PR, stacked on this one.libs/analytics-events/EVENTS.mdis regenerated, andTransferEventsTestasserts the new value and event as literals.