Repository navigation
fix(chat): tighten cash bubble spacing - #1953
Merged
Merged
Conversation
The cash bubble was taller than the spec (docs/specs/cash-bubbles.md, node 13266:348). Outer padding goes from 20 to 15, the caption, money and counterpart gaps from 20 to 10, and the currency gap from 15 to 5. The gaps move to the static 5dp grid so each value maps down to the same step at every screen width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cash bubbles in chat were taller than the spec. A DM cash bubble measured 194dp on a 411dp-wide phone; it's now 154dp. A group send to three people (with the total line) goes from 206dp to 166dp.
The spacing values come from the updated cash-bubbles spec (code-payments/flipcash-client-orchestrator#112, design node 13266:348). One
CashBubbledraws both DM and group bubbles, so this one change covers both.Token mapping
Each value maps to the nearest
staticGridstep (5dp) at or below the spec value. The gaps used to come fromgrid, which scales with screen width (7.5dp steps on tablets), so they now usestaticGrid, the same grid as the bubble's own padding.staticGrid.x2+staticGrid.x1staticGrid.x2staticGrid.x1None of the three changed values lands on a token: 16 → 15, 12 → 10, 6 → 5. Together they leave the Android bubble 7dp shorter than a bubble built to the exact spec values. If iOS uses the exact values, the two apps won't reach the same height until one side changes.
Screenshots
DM bubble ("You sent $1.00 / Jeffy / to Ada Lee") on a 1080×2400, 420dpi emulator, before and after:
Group bubble (the
Preview_CashBubble_GroupSenderpreview rendered in Robolectric at 411dp wide), before and after. The test account has no group send to two or more people, so there is no device screenshot of one: