Repository navigation
fix(group-requests): keep the strip's text and Pay button whole as the deck collapses - #1137
Merged
Merged
Conversation
…e deck collapses
The moving card that carries the front request back into the owed strip
drew no Pay button and laid the strip's title and owed line out at
exactly their measured widths. On the frame before the real strip took
over, the strip showed at full width with no Pay button and both lines
truncated ("Monday Requ…", "You owe $2 · 7 days…").
The moving card now draws the Pay button at its measured spot, held
against its trailing edge and fading in over the last 35% of the
collapse, and gives the strip's text a point of slack over its measured
width so it doesn't round down into truncation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the expanded deck collapses back into the owed strip, one frame shows the strip at full width with no Pay button and both lines cut off: "Monday Requ…" and "You owe $2 · 7 days…". The next frame is the real strip, with the full text and the green Pay button.
That frame is the moving card in
PaymentRequestDeckMorph, resting at the strip just before the strip itself takes over. It had two gaps:DeckPart.pay), held the same distance from the moving card's trailing edge, and fades it in over the last 35% of the collapse, the same curve the amounts line uses. Expanding fades it out the same way. The capsule moved intoPaymentRequestStripPayLabelso both draw the same thing.