Repository navigation
feat(chat): scaffold flipcash2 0.23.0 contract - #1157
Merged
Merged
Conversation
Build against the unreleased contract via the local override; the 0.22.0 pin is unchanged. - push: SendTestPush service call, ErrorSendTestPush and FlipClient.sendTestPush - chat: EditChat takes full replacement rules; INVALID_RULES and RULES_NOT_SATISFIED map to ErrorEditChat cases - chat: MetadataUpdate.RulesChanged decodes to ConversationStreamEvent.rulesChanged and updates the store and persisted conversation - events: ChatUpdate.payment_request_updates decode to DecodedPaymentRequestUpdate; applying them to request state is a TODO - activity: Activity.requestedPayment from the new oneof context; boosted reaction now reads the oneof instead of hasBoostedReaction
bmc08gt
force-pushed
the
feat/flipcash2-0.23.0-scaffold
branch
from
October 29, 2026 04:17
a993c9d to
59e98f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scaffolds the flipcash2
0.23.0contract and bumpsflipcash2-client-protocolfrom0.22.0to0.23.0, with the pin andPackage.resolvedin one commit. Client PR: code-payments/flipcash2-client-protocol#31boostedReactionmoved intooneof context, sohasBoostedReactionis gone.Activity+Metadata.swiftswitches oncontextinstead.SendTestPush:PushService.sendTestPushandFlipClient.sendTestPush(owner:), withErrorSendTestPush.EditChatrules:rules: ConversationRules? = nilthroughFlipClient.editChat.ErrorEditChatgains.invalidRulesand.rulesNotSatisfied; the wire-number test covers 7 and 8.RulesChanged:ConversationStreamEvent.rulesChanged, applied byConversationStore.applyRulesChangedand persisted byConversationController.ConversationStreamEvent.paymentRequestsChangedcarriesDecodedPaymentRequestUpdate. Applying them is a TODO, since nothing holds request state yet.RequestedPayment:Activity.requestedPayment. It is not persisted: storing it needs a new table and a schema bump, so it reads backnilfrom the database.No UI. Tests added:
decodesRulesChangedanddecodesPaymentRequestUpdates.