Repository navigation
feat(ui): redesign showcase — chat v2, rows v2, SF type, Central icons, trays, swipe-to-send, group profile (draft) - #1159
Draft
aidenjwalker wants to merge 43 commits into
Draft
aidenjwalker wants to merge 43 commits into
aidenjwalker wants to merge 43 commits into
Conversation
… a failure look Same gesture, thresholds, nudge and commit order as before; the commit rule moves into SwipeControl.shouldCommit unchanged.
Callers' throws reset silently as before. One press feedback (interactive glass off by default), 0.4 s snap-back, Reduce Motion crossfades, shared glass helper, token colours.
… the label shimmer The swipe gets its own 64 pt height; trays keep 54.
Same side and bottom insets as the amount-entry button; layout only.
…unt screen with swipe travel Progress reaches EnterAmountView through SwipeControlProgressKey; visual only.
This reverts commit 732ffb0.
Final values as constants, tuner removed from the control; glass thumb and fill looks removed; release haptic only on a non-committing release.
… off rest, keep errors bright
Derives a deep page colour and a text palette from an image, dark only, with the Recipes prototype's tuned defaults baked in.
The public branch of ChatProfileScreen draws the cover melting into its own colour, an identity block with outline Share/Edit pills, requirement tiles, a chatting-recently pulse card and a capsule Open Chat. The private branch is unchanged.
Every LOCAL-TUNER value is baked to its default in the call site's original form; tuner wiring, floating panels and the profile playground entry are gone. FlipcashUI is back on the iOS 18 floor with no TunerKit dependency.
Catches the redesign up with 86 upstream commits (protocol 0.23.0, invite links, payment requests, group send, paid reactions, chats search, display currency). Conflicts keep upstream's behaviour, data, navigation and money handling with the redesign's look. Group payment cards use upstream's layout in the redesign's style; the payment-request card is a neutral money card; public profile requirement tiles now restate amounts in the display currency.
Jump-to-bottom rides the bar; the profile's chatter pile opens the full chatter list; accessibility labels, hit areas, Dynamic Type wrapping, iOS 18 fallbacks, tray button stacking and the SE amount inset.
…receipt exit fade Chat bubble, quote, media, run-gap and tab-badge tests read the redesign's values from ChatStyle and its metrics. The 4pt run gap brings the next bubble over the receipt line sooner, so its exit fade drops to 0.065 s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, not for merging. This is a showcase of the whole redesign so the team can see it in one place, caught up with today's
main. I'd love your input on:Warning
System-wide change: the app background is now #121212 (was the
backgroundasset, #19191A).backgroundMaincarries it to 197 references in 148 files, plus the colour asset, the launch screen, the notification extension and the tip-card export.backgroundSecondary(#252526) hasn't been re-stepped from it yet. The Figma token still says #000000.What's here, screen by screen
Chat (v2)
Rows v2 and lists
ListRow(60pt minimum height, 20pt margins, 30pt leading slot, a hairline that starts at the text).Type and icons
FontBook, plus system nav titles.Icon,Image.icon) replace SF Symbols and the old asset set across the tab bar, wallet, currency info, settings, composer, camera and back arrow.Trays
DialogItemnow shows as a tray through the existing.dialog(item:)seam (48 call sites, no call-site changes).Swipe-to-send (Lens)
SwipeControl: a capsule track, and a Liquid Glass thumb over a Metal lens shader. iOS 18 gets a material thumb.Public group profile
Theme/Bleed).GroupBalanceRequirements.formatted(…in:).GroupChattingGridin a tray and then pushes the profile as before.Caught up with main
I merged
upstream/main(86 commits, protocol 0.23.0) instead of rebasing. On every conflict your behaviour, data, navigation and money handling won, and the redesign supplied the look. The redesign doesn't use any contract type the 0.23.0 bump changed.Your screens the redesign never touched are not restyled yet and still look v1:
Anything built on restyled tokens or components picks up the new look partly.
Behaviour changes for you to confirm
mainmutes on tap. Aiden prefers the two-step.Known gaps
.custom(_:size:)did. Fixing it touches about 550 call sites or needs type roles.FlipcashUITestswasn't run.Mid-flight
backgroundSecondary, and how far the profile cover melts (shortened from 214pt to about 94pt so the group name stays readable over light covers). The values in the build are the current defaults.Open questions for you, by area
Group profile pages
Trays
DialogItem?CADisableMinimumFrameDurationOnPhoneis unset, which may cap custom animation at 60 Hz.Chat v2
Rows v2
ListRow? The visible changes: settings icon slot 45 → 30, currency coin 24 → 30, region flag 30 → 28 with a check instead of a disc.Swipe-to-send
Parked dev items
CodeButton(60pt, radius 6) is deprecated. Trays, the amount screen and the profile each use a 54pt capsule. We need one shared style and a decision on screen-level button height.Decided by Aiden
How to see it
--motion-sandboxand--swipe-sandboxopen sandboxes that need no sign-in.Checks
Scripts/build.shpasses unsigned; there are no new warnings on the lines this branch changed.FlipcashCoreTests: 1,583 tests pass.FlipcashTests: all 3,323 tests pass. The chat bubble, quote, media, run-gap and tab-badge tests now read the redesign's values fromChatStyleand its metrics.FlipcashUITestsnot run.