Repository navigation
feat(analytics): send the shared catalogue's money, Wallet and onramp events - #1195
Merged
Merged
Conversation
Adds Token Purchase With Coinbase at the order's outcome, Onramp: Show Verification Info on the intro screen, the Buy With Coinbase and Buy With Phantom buttons at amount confirm, and Deeplink: Parse's failure form for a scanned code that is no Flipcash link. Each fires where Android's does.
Withdrawal, the transfer events, Tip Received, the Add Money steps, Token Purchase and Token Sell now go through the shared builders, so each sends Fiat, Currency, USDC and Quarks, plus Exchange Rate and Mint when known. Grab Time is sent in ms. Token Purchase and Token Sell now fire on the submit result, as Android's do, instead of when the swap finishes; a convert reports as a sell of its source. State, Payment Mint and the completion-time sends are gone. A Phantom Add Money failure sends no amount, as on Android.
…droid does Every Wallet event now goes through the shared builders with Provider Phantom. Wallet: Connect fires once Phantom returns a session instead of on the request, and Wallet: Cancel only on a user reject (4001). Wallet: Transactions Failed is new: it fires when the chain refuses a transaction Phantom signed, at simulation or send, except for an expired blockhash, matching Android's send failure. Wallet: Request Amount sent Fiat 0: ExchangedFiat.compute values USDC as a bonded mint with no supply and returns zero. It now sends the USDC amount in USD, valued with USDC's 6 decimals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS now sends the shared catalogue's form of the money, Wallet and onramp events, so Mixpanel can chart iOS and Android in one series. Every send goes through the SharedCore 0.18.0 builders (the pin on
main).Three commits: events iOS never sent, the
amountgroup on money events, and the Wallet events.Token Purchase and Token Sell now mean "submitted". They fired when the swap finished; they now fire on the submit result, as Android's
SwapViewModel.trackTransactiondoes. A dashboard comparing before and after this release will see that shift.Wallet: Request Amount sent Fiat 0.
sendUsdcToUsdfSignRequestvalued the USDC withExchangedFiat.compute, which treats any non-USDF mint as bonded and returns zero with no supply.TokenAmount.decimalValueis no fix either:mintDecimalsis 10 for every non-USDF mint, USDC included.WalletConnection.usdValue(of:)now uses USDC's 6 decimals. The same zero went into the "Requested USDC→USDF deposit swap" log line.SwapEvents.purchase,placeOrderAndStartPaymentresultCoinbaseDepositOperation.trackPurchase→Analytics.tokenPurchasetrackTransaction(SwapViewModelErrorTestexpects Reserves)SwapEvents.purchase,trackTransactionSwapCompletionReporter.trackSubmit→Analytics.tokenPurchaseSwapEvents.sell,trackTransactionSwapCompletionReporter.trackSubmit→Analytics.tokenSellOnrampEventson the intro screenOnrampVerificationIntroScreen.task→Analytics.onrampStep(.showInfo)ButtonEvents.tappedon picking a method with an amountAddMoneyAmountViewModel, next to Amount ConfirmedDeeplinkEvents.parseFailed, scannerScanViewModel.isUnparseableQR→Analytics.deeplinkParseFailedTransferEvents.*Analytics.transfer/Analytics.withdrawalTransferEvents.grabBillAnalytics.transferTransferEvents.sendCashLinkAnalytics.transferChatEvents.tipReceivedAnalytics.tipReceivedAddMoneyEvents.*Analytics.addMoneyAmountConfirmed/addMoneyPaymentInvokedAddMoneyEvents.resultAnalytics.addMoneyhandlePhantomErrorWalletEvents.connectafter connectingAnalytics.walletConnected, when Phantom returns a sessionWalletEvents.cancelon a user rejectAnalytics.walletCancelled, on code 4001 onlyFailedToSendTransaction, a send failure other than an expired blockhashPhantomDepositOperationsimulate or send refusal, other than an expired blockhashWalletEvents.requestAmountwith the USDC amountAnalytics.walletRequestAmountDropped because the builders can't carry them: State, Payment Mint and Payment Token Symbol on Token Purchase; State on Token Sell. Gallery Scan: Succeeded / Failed already shipped in #1170, so there was nothing to rename. Create Account keeps Owner Public Key; it is untouched here.