refactor(agent-manager): organize Claude provider code - #198
Merged
Conversation
…cator rationale The Claude provider reorganization left three private delegation methods on ClaudeCodeAdapter (discoverSessions, tryPidFileMatching, getProjectDir) with no production callers — they existed only so the adapter test suite could keep reaching them through `(adapter as any)`. Move those 19 tests onto ClaudeSessionLocator, delete the proxies, and re-narrow tryPidFileMatching and getProjectDir to private now that nothing outside the locator calls them. Also carry across the explanatory comments dropped during the extraction: the PidFileEntry field docs (including why live PID-file status beats JSONL-derived state), the PID_FILE_STALENESS_MS recycling rationale, the lossy path-encoding note on getProjectDir, the worktree caveat on discoverHistoricalSessionFiles, the resume-matching and readMatchingPidFile docs, and the live-status precedence comment on mapSessionToAgent. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
providers/claudeagent-managerroot exports to high-level public APIsValidation
npm run nx -- test agent-managernpm run typecheck,npm run lint, andnpm run buildinpackages/agent-managerRisk
src/index.ts.