Replace pickadate-rails with native date/time inputs - #2814
Open
mroderick wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
I verified this locally. I encourage reviewers to do the same. |
mroderick
marked this pull request as ready for review
August 26, 2026 21:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unmaintained pickadate-rails gem and replace its date/time pickers with native HTML5
input type="date"andinput type="time".All virtual attribute parsing (local_date, local_time, expires_at) already goes through DateTimeConcerns#datetime_from_fields, which uses Date.parse and Time.zone.parse — both accept the YYYY-MM-DD and HH:MM formats natively.
I decided to add more tests, i.e. new controller specs, in order to feel confident that tests would notify a contributor that things might break, if they change the inputs'
typeattributes.Removed
pickadate-railsgem and Gemfile.lock entry//= require pickadate/*fromapplication.js*= require pickadate/*fromapplication.scss.pickadate()and.pickatime()Changed
New test coverage
render_viewsfor every form: verifytype="date"/type="time"inputs render and pre-fill with ISO formatexpires_atdate round-trips correctlyTest results
Manual verification steps
Start the app locally (
bundle exec rails server), log in via GitHub OAuth as an admin, then:1. Workshops —
/admin/workshops/new2. Events —
/admin/events/new3. Meetings —
/admin/meetings/new4. Announcements —
/admin/announcements/new5. Bans —
/admin/members/:id/bans/new(pick any member)Regression checks