Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5685: the file path in Scenario Steps was mapped back to the original
.tsfile, but line/column still came from the transpiled.temp.mjs(TypeScript's emitter elides statements and drops blank lines, so positions shift).This transpiles with
transpileModuleand inlines the source map into each temp file, then maps step stack frames back to the original.tspositions via the map (accounting for injected CommonJS shims by shifting the map's generated lines). The previous path-only replacement stays as a fallback. Verified end-to-end with the repo's own sandbox:✔ I.doThing("from page") at Object.open (./pages/fooPage.ts:4:11)✔ I.doThing("from page") at Object.open (./pages/fooPage.ts:7:7)(correct)New unit tests cover the mapping helper (including the shim line-shift path); the existing
typescript_step_pathsrunner test now asserts the exact position. Emitted code is byte-identical totranspile()apart from the map comment.Fixes #5772.