Skip the pypy3 sample environment test on Darwin - #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sample-environments (macOS)is still red onmainafter #102, with the same 4 failures:#102 gated the pypy3 sample environment out of the Darwin flake outputs, since PyPy's bootstrap
interpreter doesn't build there. But this suite enumerates the
sample_environments/*.nixfilesfrom disk via Template Haskell and builds
.#sample_environment_<name>for each, so on Darwin itnow asks for an attribute that doesn't exist. Same failure, different cause — my miss in #102.
The file list is filtered against what the platform actually provides, mirroring the gating in
sample_environments.nix.Testing
pypy3.nixstill runs and passes under--sample-environmentson Linux, so only Darwin is affected.Note
sample_environments.nixalso drops julia110, julia111, mega and python3{,11,12,13} onaarch64-linux (issue #96). Those would hit this same problem, but the
sample-environmentsjob onlyruns on x86_64 Linux and macOS, so it isn't reachable today. If that job ever runs on aarch64-linux,
unavailableHereneeds the corresponding entries — or the list should come from the flake ratherthan the filesystem.