Repository navigation
Split the wire protocol into its own package - #3
Merged
Merged
Conversation
thomasjm
force-pushed
the
protocol-package
branch
3 times, most recently
from
November 12, 2026 09:29
ba69bb2 to
e23a26a
Compare
thomasjm
force-pushed
the
protocol-package
branch
from
November 12, 2026 10:11
e23a26a to
ddf329e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render.Protocolmoves into its own package so the codedown runner can depend on the protocoltypes instead of hand-copying them. The runner currently duplicates half of them, and the copies
have drifted:
phaseis aMaybe Textthere,encodingandstreamareTextrather thanenums, and the outgoing commands are built as raw aeson objects.
The package depends only on base, aeson, containers and text, so a client doesn't pull in
lsp,the C sources, or this repo's snapshot.
Also adds
Notification,notificationTaskIdandparseNotification, so a client can read anotification from the method it arrived on and route it without parsing the params twice.